Skip to content

Save parameters of generated waveform #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 28, 2022
Merged

Conversation

timoML
Copy link
Contributor

@timoML timoML commented Oct 17, 2022

With this change, the parameters of a generated waveform (eg. for generate_rabi: tau_start, tau_step, num_of_points) are saved with the measurement data. This makes it a lot easier to keep track of saved experimental results.

Description

Exemplary saved file of a pODMR experiment:
image

Current catch (even prior to this change):
All meta-info saved from the pulsed module are the status variables at the time of hitting the save button. This doesn't necesarily correspond to the measured signal, as it is possible to change settings of the module after a measurement was finished.

How Has This Been Tested?

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

Sorry, something went wrong.

@timoML timoML marked this pull request as ready for review November 11, 2022 09:16
@timoML
Copy link
Contributor Author

timoML commented Nov 11, 2022

@Neverhorst I made the generation_method_parameters their own entity, separate from ensemble.sampling_information and measurement_information as discussed. This requires to make the generation_method_parameters a property of pulsed_measurement_logic, which feels a little unelegant to me.

Copy link
Member

@Neverhorst Neverhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Thank you.

@NicolasStaudenmaier
Copy link
Contributor

Works well on my setup.

@timoML timoML merged commit 78ccdb6 into main Nov 28, 2022
@NicolasStaudenmaier NicolasStaudenmaier removed their request for review November 28, 2022 16:31
@timoML timoML deleted the pulsed_save_wave_kwargs branch November 28, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants