Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Millennia ev laser #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Millennia ev laser #14

wants to merge 4 commits into from

Conversation

takuya-ulm
Copy link
Contributor

@takuya-ulm takuya-ulm commented Mar 9, 2022

Description

  • Bug fix
  • Introduce VISA class and Command classes

Motivation and Context

  • Some bugs were found in transition to the new core
  • Even though the visa package was used in several laser hardware, it was not encapsulated.

How Has This Been Tested?

Tested with Millennia eV laser.
This hardware change does not have a big effect on the other area of the code.

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

@takuya-ulm takuya-ulm marked this pull request as ready for review March 14, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant