Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CsvDataStorage fix #134

Merged
merged 3 commits into from
Feb 3, 2025
Merged

CsvDataStorage fix #134

merged 3 commits into from
Feb 3, 2025

Conversation

TobiasSpohn
Copy link
Contributor

Description

CsvDataStorage correctly loads all lines of data in a measurement data csv file. Fix is similar to fix in #128.

Motivation and Context

When using CsvDataStorage to load data from a csv file, saved with the same interface, the first line of data is skipped.
This is due to a +2 added in the np.genfromtxt call option skip_header. Changing to a +1 correctly loads all lines of data.

How Has This Been Tested?

Jupyter Notebook calling CsvDataStorage.load_data(file_path) on a file created by the qudi-iqo-modules.pulsed_measurement_logic.save_measurement_data(storage_cls=CsvDataStorage)

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

@TobiasSpohn TobiasSpohn changed the title Csv data storage fix CsvDataStorage fix Jan 28, 2025
Neverhorst
Neverhorst previously approved these changes Feb 3, 2025
Copy link
Member

@Neverhorst Neverhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@Neverhorst Neverhorst merged commit fe244a5 into main Feb 3, 2025
@Neverhorst Neverhorst deleted the csv_data_storage_fix branch February 3, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants