Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CsvDataStorage
correctly loads all lines of data in a measurement data csv file. Fix is similar to fix in #128.Motivation and Context
When using
CsvDataStorage
to load data from a csv file, saved with the same interface, the first line of data is skipped.This is due to a
+2
added in thenp.genfromtxt
call optionskip_header
. Changing to a+1
correctly loads all lines of data.How Has This Been Tested?
Jupyter Notebook calling
CsvDataStorage.load_data(file_path)
on a file created by thequdi-iqo-modules.pulsed_measurement_logic.save_measurement_data(storage_cls=CsvDataStorage)
Types of changes
Checklist:
/docs/changelog.md
.(syntax, indentation, mutable default values, etc.).