Skip to content

Commit

Permalink
Adding note for minimum recommended firmware as a once only log
Browse files Browse the repository at this point in the history
  • Loading branch information
mjstn committed Nov 16, 2023
1 parent e286ebe commit 52a35ba
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions include/ubiquity_motor/motor_message.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ typedef boost::array<uint8_t, 8> RawMotorMessage;
#define MIN_FW_WHEEL_NULL_ERROR 38
#define MIN_FW_PID_CONTROL_REV2 39
#define MIN_FW_DRIVE_TYPE 42 // Separated wheel type from drive type July 2021
#define MIN_FW_SUGGESTED 43 // We suggest this as the firmware to use if fw is lower revision

// It is CRITICAL that the values in the Registers enum remain in sync with Firmware register numbers.
// In fact once a register is defined and released, it should NOT be re-used at a later time for another purpose
Expand Down
11 changes: 11 additions & 0 deletions src/motor_node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,17 @@ void initMcbParameters(std::unique_ptr<MotorHardware> &robot )
mcbStatusPeriodSec.sleep();
}

// Suggest to customer to have current firmware version
if (robot->firmware_version < MIN_FW_SUGGESTED) {
ROS_ERROR_ONCE("Firmware is version V%d. We strongly recommend minimum firmware version of at least V%d",
robot->firmware_version, MIN_FW_SUGGESTED);
mcbStatusPeriodSec.sleep();
} else {
ROS_INFO_ONCE("Firmware is version V%d. This meets the recommend minimum firmware versionof V%d",
robot->firmware_version, MIN_FW_SUGGESTED);
mcbStatusPeriodSec.sleep();
}

// Certain 4WD robots rely on wheels to skid to reach final positions.
// For such robots when loaded down the wheels can get in a state where they cannot skid.
// This leads to motor overheating. This code below sacrifices accurate odometry which
Expand Down

0 comments on commit 52a35ba

Please sign in to comment.