Linear and rotational part as separate maneuvers - #95
Merged
Conversation
MoffKalast
suggested changes
Jun 8, 2021
| double finalYaw = goalYaw - (yaw + requestedYaw); | ||
| if (std::abs(finalYaw) > angularTolerance) { | ||
| if (!rotate(finalYaw, drivingFrame)) { | ||
| return; |
Contributor
There was a problem hiding this comment.
I think we're missing a actionServer->setSucceeded(); over here, the state still never gets changed from active right now.
Contributor
There was a problem hiding this comment.
But otherwise it does work 👍
dorkamotorka
commented
Jun 8, 2021
| sleep(localizationLatency); | ||
| } | ||
|
|
||
| actionServer->setSucceeded(); |
Contributor
Author
There was a problem hiding this comment.
@MoffKalast this line is setting it as succeeded
Contributor
There was a problem hiding this comment.
It doesn't seem to get that far apparently. I'm not sure what rotate() gives back at specific times, but I'd imagine it just returns without setting the status in line 503?
Contributor
Author
There was a problem hiding this comment.
Hmm, yes it could be possible that the boolean we are returning from rotate function is wrong. If you are able to reproduce the issue, reopen it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve #94