Update empty_world.launch #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfederman
assigned anfederman, SkofAljaz and MoffKalast and unassigned anfederman and SkofAljaz
|
I hope Vid can check this out. |
MoffKalast
suggested changes
Jul 28, 2022
There was a problem hiding this comment.
Ok I would advise against this one, since this file is used as a generic gazebo launcher, with people then loading up a separate launch file for various different nav stacks (so if that needs to be reset gazebo doesn't need to be reloaded).
I would suggest you add the move_base launch file in the launch file that launches the demos, since it's a dependency of those and not gazebo. Even the regular base.launch doesn't start move_base so you'll need that included regardless if you want it to run on a real robot.
Open
|
Let's just make all required changes in #215, it should be easier to keep track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with the pull request alanfederman-4 this allows various demos that rely on move_base to work in gazebo.
This also will work if move_base is launched in magni_bringup on a real robot.
Unknown if this conflicts with maps made by lasers or sonars.