-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conveyrobot docs update #76
base: master
Are you sure you want to change the base?
Conversation
I am away from home until Sunday. I will review next week.
…On Fri, Apr 14, 2023, 10:20 AM mbostic ***@***.***> wrote:
I have updated the Conveyorbot docs to the point that I think they are
ready to be sent to potential users. I think it is of high importance to
send this manual to potential buyers of Conveyorbot, because it includes
many details of how the robot works.
@davecrawley <https://github.com/davecrawley> I think also you should
read through the docs carefully, so that you will have a better idea of the
robot and will be able to better present it to potential buyers.
------------------------------
You can view, comment on, or merge this pull request online at:
#76
Commit Summary
- abac575
<abac575>
CB doc update
File Changes
(3 files <https://github.com/UbiquityRobotics/learn/pull/76/files>)
- *M* noetic/conveyorbot/fiducials.md
<https://github.com/UbiquityRobotics/learn/pull/76/files#diff-766810670d58fa305c1cc1dee0c0bf10e32779dd9252fe18d98966a7c31b86ea>
(37)
- *M* noetic/conveyorbot/routesetup.md
<https://github.com/UbiquityRobotics/learn/pull/76/files#diff-dec9103ebf3a542fe6b644fbb0839da35ae8b48381f3d09503fe8fa46fc325de>
(25)
- *M* noetic/conveyorbot/usage.md
<https://github.com/UbiquityRobotics/learn/pull/76/files#diff-376aece0eeee007310f8032aed772eee233322a2c7bee23fe709711c34b0df0c>
(42)
Patch Links:
- https://github.com/UbiquityRobotics/learn/pull/76.patch
- https://github.com/UbiquityRobotics/learn/pull/76.diff
—
Reply to this email directly, view it on GitHub
<#76>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHZ374KLEDZFIWMVC64FX3XBFMLDANCNFSM6AAAAAAW6PTPRE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Alright, so while we're at it I've fed the files into GPT 4 to make them easier to read. I've checked it all and I think the information is all the same as before, just worded a bit differently and sometimes a lot more concisely, especially those walls of text. @mbostic can you give them a quick re-check anyway just to be sure? We should probably feed the entirely of learn into it for grammar checks once someone has the time haha. Or as it would say (for comparison):
|
@MoffKalast It seems like a good idea to do this kind of processing with GPT-4, since it really improves wording of sentences and fixes grammar problems, but I think the results should be checked carefully. |
Yeah agreed that it could use some additional explanations here and there. There's a lot of places where shortening the description makes the data less explicit and easier to miss. I did highlight a thing or two in bold, but we likely need more of that.
I guess that depends on what's the exact intention there. In the sense where you're laying down the route "creates" makes more straightforward sense, but it doesn't imply that you have to input the marker into the route itself on the touchscreen, so "can be used" might be more accurate. I doubt anyone would pick up on that detail while reading it for the first time though, so it should be specified far more clearly than both of these options. Maybe we can let @anfederman read through it first to see where he gets most confused and work on that. |
@MoffKalast @davecrawley @anfederman I read through the GPT4's fixes and they seemed mostly ok and I just did two minor fixes. |
I have updated the Conveyorbot docs to the point that I think they are ready to be sent to potential users. I think it is of high importance to send this manual to potential buyers of Conveyorbot, because it includes many details of how the robot works.
@davecrawley I think also you should read through the docs carefully, so that you will have a better idea of the robot and will be able to better present it to potential buyers.