Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing dependencies for message generation #246

Closed

Conversation

Acuda
Copy link

@Acuda Acuda commented Mar 25, 2021

No description provided.

@JanezCim
Copy link
Contributor

JanezCim commented Apr 2, 2021

Thank you for your contribution :)
I dont see how this is necessary, since this line

<depend>fiducial_msgs</depend>

makes sure those dependencies are met. So even if I try to compile fiducial_slam with
catkin_make --only-pkg-with-deps fiducial_slam
there still will be no error. Do you have a specific use-case where those changes are necessary?

@JanezCim JanezCim self-assigned this Apr 2, 2021
@Acuda
Copy link
Author

Acuda commented Apr 6, 2021

not a real specific use-case, also as suggested here http://wiki.ros.org/ROS/Tutorials/CreatingMsgAndSrv#Using_msg or for the srv/AddFiducial.srv case http://wiki.ros.org/ROS/Tutorials/CreatingMsgAndSrv#Using_srv message generation is recommend.

[...]We need to make sure that the msg files are turned into source code for C++, Python, and other languages[...]

the specific use-case is "other languages", in detail: message generation for java. but nevertheless, according to the links above i think message generation is still missing. but i am also fine to use my branch, i can build it. just thought you (and others?) where also interested in the changes i made. :)

@Acuda Acuda closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants