This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Finished mailroom oop #1557
Merged
Finished mailroom oop #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ramr24 nice work! you have the basics of OO but yes like you mentioned the organization would need to be addressed.
| try: | ||
| donation_amount = input_donation() | ||
| except ValueError: #ValueError if not integer/float | ||
| print("Please enter an integer.") |
There was a problem hiding this comment.
there should be no input functions in your data classes (even if input() is not directly called)
| elif user_response == 4: | ||
| exit_program() | ||
| elif user_response not in range(1,4): | ||
| print("Please enter a valid number within 1-4!\n") |
There was a problem hiding this comment.
switch dict would be more appropriate here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will continue to work on this since this mailroom oop project as I know this is not a fully finished code without separating code into cli.py and not having a test.py. I will definitely finish and organize my code to a better stage before starting my next course.