Missing Exercises #226
Open
Missing Exercises #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 30, 2018 17:02
added 21 commits
December 13, 2018 02:00
|
FyFy -- yup, html_render is challenging -- that's why it's so many points. Taking a look .... |
|
you've accidentally added pycache directories -- be careful! I think that happened because you deleted the .gitignore. but also -- you need to be careful with |
|
giving you full credit to html_render, which brings you JUST 20 80%. But you really want to do OO mailroom and html_render to make sure you understand OO programming. I also don't see a trigrams -- that's another good one -- maybe go back and give it a try again -- you may be surprised, now that you have a bit more experience. |
|
not merging, due to git issues -- and class is over anyway :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
Last few completed assignments are included in this PR. This should put me right at the 80% completed...
Html render: this one was a beast. So hard. I did my best but its current state is kind of a hot mess. I haven't quite gotten all the tests to pass and everything working right. Everything seems to be failing more the more I refactor... I need to keep working on this one but likely won't be be able to push any updates before you submit.
circle.py: after doing html render... I didn't think it was possible to see green and pass all tests! Got it working though and all tests pass.