Migrate to gar #21
Merged
Migrate to gar #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miker985
commented
Sep 18, 2024
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: ${{ github.repository }} | ||
| REGISTRY: us-docker.pkg.dev/uwit-mci-iam/containers | ||
| OWNER_IMAGE: ${{ github.repository }} |
There was a problem hiding this comment.
Updating REGISTRY is pretty straight-forward, but getting the image name right isn't.
github.repository is in this case uwit-iam/nginx-saml-proxy but we only want nginx-saml-proxy...
miker985
commented
Sep 18, 2024
| id: image_name | ||
| run: | | ||
| # GH=uwit-iam/nginx-saml-proxy; echo ${GH#*/} returns "nginx-saml-proxy" | ||
| echo "IMAGE_NAME=${OWNER_IMAGE#*/}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
... so we compute it
|
You may already be thinking of this but remember this repo is public so be thoughtful about what is hardcoded in workflows and files. |
counik
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginx-saml-proxy is a core piece of the example-flask-app that several MCI apps are based on.
This successfully ran and pushed a new image to our "containers" registry in GAR in this Action run
I haven't actually tested it live because I don't think there's anything about this that meaningfully impacts that.
It appears to me that the ghcr.io image wasn't even used as gcp-k8 shows nginx-saml-proxy is a docker.io image so I'll need to spin this up in dev and see if anything unfortunate happens...