Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cron job for generating CDSA records #398

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Jan 24, 2024

  • Modify the cdsa_records command to accept --outdir as a keyword argument instead of as a positional argument

@amstilp amstilp linked an issue Jan 24, 2024 that may be closed by this pull request
5 tasks
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b18d9e6) 98.30% compared to head (b13c4d2) 98.30%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         233      233           
  Lines       18037    18053   +16     
=======================================
+ Hits        17731    17747   +16     
  Misses        306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amstilp
Copy link
Contributor Author

amstilp commented Feb 16, 2024

@jmcarson is this ready to go? And then are there instructions anywhere for adding the updated crontab file to cron when deploying?

@jmcarson
Copy link
Collaborator

Yes, ready to go from my perspective. To install run:
sudo -u <deployment_user> crontab <crontab_file>
I thought I added to docs, but have not yet.

@jmcarson
Copy link
Collaborator

I can deploy and update the docs at the same time, but probably not until Monday

@amstilp amstilp marked this pull request as ready for review February 21, 2024 23:01
@amstilp amstilp merged commit 5e927db into main Feb 21, 2024
8 checks passed
@amstilp
Copy link
Contributor Author

amstilp commented Feb 22, 2024

@jmcarson I deployed this and I think I set up the cron job - I'll let you know if I don't see it run next weekend.

@amstilp amstilp deleted the feature/cdsa-records-cron branch April 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create automatic data retention reports for CDSA data
2 participants