Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "replaced" status for CDSAs #384

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Add "replaced" status for CDSAs #384

merged 4 commits into from
Jan 20, 2024

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Jan 19, 2024

  • Add a new "replaced" status value for SignedAgreements

This status indicates CDSAs that were replaced by newer agreements.
We do not maintain a link to the CDSA that it is replacing in django;
that is handled in outside pre-tracking.
@amstilp amstilp marked this pull request as ready for review January 19, 2024 00:15
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6975fc0) 98.29% compared to head (6b8d3ef) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         232      233    +1     
  Lines       18024    18037   +13     
=======================================
+ Hits        17717    17731   +14     
+ Misses        307      306    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These lines are not code, just documentation of a variable, so they
shouldn't count against our coverage metric.
@amstilp amstilp merged commit 6a06dab into main Jan 20, 2024
8 checks passed
@amstilp amstilp deleted the feature/cdsa-status-replaced branch January 20, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant