Skip to content

Commit

Permalink
Merge pull request #399 from UW-GAC/feature/hide-some-links-from-view…
Browse files Browse the repository at this point in the history
…-users

Hide dbGaP audit link from view users
  • Loading branch information
amstilp authored Jan 24, 2024
2 parents b18d9e6 + ac9e62a commit 14fefc3
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
36 changes: 36 additions & 0 deletions primed/dbgap/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,42 @@ def test_response_contains_dbgap_link(self):
response = self.client.get(obj.workspace.get_absolute_url())
self.assertContains(response, obj.get_dbgap_link())

def test_links_audit_access_staff_view(self):
user = UserFactory.create()
user.user_permissions.add(
Permission.objects.get(
codename=AnVILProjectManagerAccess.STAFF_VIEW_PERMISSION_CODENAME
)
)
obj = factories.dbGaPWorkspaceFactory.create()
self.client.force_login(user)
response = self.client.get(obj.get_absolute_url())
self.assertContains(
response,
reverse(
"dbgap:workspaces:audit",
args=[obj.workspace.billing_project.name, obj.workspace.name],
),
)

def test_links_audit_access_view_permission(self):
user = UserFactory.create()
user.user_permissions.add(
Permission.objects.get(
codename=AnVILProjectManagerAccess.VIEW_PERMISSION_CODENAME
)
)
obj = factories.dbGaPWorkspaceFactory.create()
self.client.force_login(user)
response = self.client.get(obj.get_absolute_url())
self.assertNotContains(
response,
reverse(
"dbgap:workspaces:audit",
args=[obj.workspace.billing_project.name, obj.workspace.name],
),
)


class dbGaPWorkspaceCreateTest(AnVILAPIMockTestMixin, TestCase):
"""Tests of the WorkspaceCreate view from ACM with this app's dbGaPWorkspace model."""
Expand Down
3 changes: 3 additions & 0 deletions primed/templates/dbgap/dbgapworkspace_detail.html
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,12 @@ <h2 class="accordion-header" id="headingAcknowledgments">


{% block action_buttons %}

{% if perms.anvil_consortium_manager.anvil_consortium_manager_staff_view %}
<p>
<a href="{% url 'dbgap:workspaces:audit' billing_project_slug=object.billing_project.name workspace_slug=object.name%}" class="btn btn-secondary" role="button">Audit application access</a>
</p>
{% endif %}

{{block.super}}
{% endblock action_buttons %}

0 comments on commit 14fefc3

Please sign in to comment.