-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/interface clarifications #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
6edb19f
added i18n tags, added links and tooltips to menu
BeritJanssen 79d53c8
adding i18n-parser
BeritJanssen 1dcafb7
merge develop
BeritJanssen a8cf83a
incorporated suggested changes
BeritJanssen 2895e63
Merge branch 'develop' into feature/interface-clarifications
jgonggrijp 9ddf02f
Fix markup of modal close button in feedback template (#451)
jgonggrijp 9dea827
Correct indentation in pagination template (#451)
jgonggrijp 7af7b78
Properly nest, don't escape markup in i18n in anno edit template #451
jgonggrijp e440981
Add {{#i18n}} tags in more places (#451)
jgonggrijp 1236e78
Add i18next.t calls in more places (#451)
jgonggrijp c482a9b
Export i18nParse function in gulpfile as task (#451)
jgonggrijp 164f7fb
Import { gulp as i18nextParser } (#451)
jgonggrijp d59b9eb
Use frontend/src/i18n as the i18nParser output directory (#451)
jgonggrijp 8408b98
Point i18nParser to the files inside the source directory (#451)
jgonggrijp 54e4d43
Configure hbs lexer for i18nParse gulp task (#451)
jgonggrijp e63744b
Use our very own handlebars-i18next-parser (#451)
jgonggrijp 91ad84b
Move i18next-parser config to a separate file (#451)
jgonggrijp 695f23f
Add exception for package.json to .editorconfig
jgonggrijp 14b38eb
Use the output of i18next-parser (#451)
jgonggrijp 1b563a8
Remove triple braces for i18n blocks in 404 and anno edit templates
jgonggrijp d2a3f8f
Document frontend localization with the new parsing setup (#451)
jgonggrijp fc250c9
Document the shorthand script in the top-level package.json (#451)
jgonggrijp be0f64d
Add i18n keys that i18next-parse cannot handle automatically (#451)
jgonggrijp e2b0e4d
Fix a discrepancy in i18n "close" key (#451)
jgonggrijp 9929899
Move anno-edit type hints entirely into translation JSON (#451)
jgonggrijp 5f0daf0
Stop i18next-parser from changing French back to English (#451)
jgonggrijp 6b665cb
Use four-space indentation in translation JSON files (#451)
jgonggrijp 4a10968
Replace _ by - in i18n keys (#451)
jgonggrijp 11af496
Place variable interpolations inside i18n strings where appropriate (…
jgonggrijp 3b0352e
Commit translation_old.json (#451)
jgonggrijp 978c0f5
Upgrade handlebars-i18next-parser to 1.0.2 (#451)
jgonggrijp 6cf200a
Treat translation strings with links consistently (#451)
jgonggrijp a6a9e83
Organize the translation strings (#451)
jgonggrijp 34900a9
Document how to prevent i18next-parser translation overrides (#451)
jgonggrijp 16ee433
Make the tooltips in the main menu point down (#448 #447)
jgonggrijp f7015a7
Decorate the menu with more tooltips (#448 #447)
jgonggrijp a485531
Expand the TooltipView test suite (#447 #448)
jgonggrijp a274d89
Supercharge TooltipView so it can be attached to subelements (#448 #447)
jgonggrijp 17c9c53
Factor TooltipModel from TooltipView (#448 #447)
jgonggrijp 5e11728
Use TooltipModel in TooltipView (#448 #447)
jgonggrijp 96a92fd
Use classes instead of ids in annotation view (#448 #447)
jgonggrijp 08440c4
Use native Promise for global/i18n (#451)
jgonggrijp 1d71075
Expose i18nPromise through radio channel for access from views (#451)
jgonggrijp 1697cfd
Use the new i18nChannel where appropriate (#451)
jgonggrijp 0622fe2
Export the Direction type from tooltip view (#447 #448)
jgonggrijp 925aeee
Move AnnotationPanel tooltips from template to view class (#448)
jgonggrijp f343847
Spend more words on the existing AnnotationPanel tooltips (#447)
jgonggrijp c77528c
Add tooltips for the remaining buttons in AnnotationPanel (#448)
jgonggrijp 5f4342b
Toggle is-tooltip-multiline class based on text length (#448)
jgonggrijp 6e87767
Factor bulk tooltip management from AnnotationPanel for reuse (#448)
jgonggrijp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<button type=button class="button is-success"> | ||
<span>Add</span> | ||
<span>{{#i18n 'add'}}Add{{/i18n}}</span> | ||
<span class="icon is-small"><i class="fas fa-plus"></i></span> | ||
</button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<button type=button class="button is-danger"> | ||
<span>Remove</span> | ||
<span>{{#i18n 'remove'}}Remove{{/i18n}}</span> | ||
<span class="icon is-small"><i class="fas fa-times"></i></span> | ||
</button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we already proactively change the Footer to only include the UU logo and DHLab name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that has been agreed, I suppose we should. I'll defer that to a separate ticket, though.