Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/semantic search #465

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Feature/semantic search #465

merged 3 commits into from
Apr 22, 2021

Conversation

jgonggrijp
Copy link
Member

This branch contains two preparations for #455, one of which fixes #426.

Heads-up @BeritJanssen: the other change moves frontend/src/panel-related-items/relation-utilities.ts to frontend/src/utilities/. If I recall correctly, you were planning to use that module, too.

I might submit more partial PRs that are part of #455 in order to spread disruptive changes like these.

@jgonggrijp jgonggrijp requested a review from BeritJanssen April 22, 2021 16:48
Copy link
Member

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I recall that I meant to move the relation-utilities file, but we decided to keep it next to the views that would use them in the end. I'm happy with moving this to the utilities folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a dedicated select2 view
2 participants