-
Notifications
You must be signed in to change notification settings - Fork 74
Refactor professor course and section pipelines into a pipeline builder function #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@ruba0s, as for merge conflicts, ideally, you should pull the new changes to your local first, manually resolve those conflicts, and push them back. Resolving shouldn't take very long if those conflicts are not really related to what you are working on. |
@mikehquan19 Sounds good! Once I'm done with that and want to commit merge, should I choose commit updates to the develop branch or create a new branch and commit updates? |
You commit merge to whichever branch you are working on, don’t create a new branch. |
api/controllers/professor.go
Outdated
|
||
// paginate the sections | ||
bson.D{{Key: "$skip", Value: paginateMap["latter_offset"]}}, | ||
bson.D{{Key: "$limit", Value: paginateMap["limit"]}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these 3 last stages here are essentially the same (since they all sort and paginate the latter object whether it's course or section), so you could potentially put them after (or before?) conditions.
Other than that, this one should be ready for merging!
No description provided.