Skip to content

Conversation

simar-rekhi
Copy link

Fixes #249

@mikehquan19
Copy link
Contributor

@simar-rekhi, can you check the build fail?

@simar-rekhi
Copy link
Author

@mikehquan19, sure!

@simar-rekhi simar-rekhi marked this pull request as draft September 22, 2025 19:58
@simar-rekhi simar-rekhi marked this pull request as ready for review September 22, 2025 19:59
@simar-rekhi
Copy link
Author

tl; dr: both ubuntu and windows are building successfully now

I think it was an issue related to Swagger Annotation. The documents we are essentially returning to the client had to be wrapped in an APIResponse Wrapper if they were to stay an {object}.

@mikehquan19 mikehquan19 self-requested a review September 24, 2025 18:42
Copy link
Contributor

@mikehquan19 mikehquan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @simar-rekhi, you are making great progress so far. There's one issue.

The route you've implemented is actually /events/:day/:building/:room instead of /events/:day/:building/:room/sections.

For /events/:day/:building/:room/sections, you would actually have to replace the ID of the sections with the actual section object.

So my suggestion is:

  • corrrect the endpoint of the route you have implemented
  • implement another one that uses the aggregate pipeline (sorry to say that) to pull the sections from the ids.

Also, try to resolve the conflicts you have since I updated new stuff. Reach out to me if you have questions.

@simar-rekhi
Copy link
Author

@mikehquan19, I'll try to finish this in today's meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create /events/:day/:building/:room/sections route for rooms
2 participants