-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer voteythumbs request (also prettified latex, and deferred xkcd) #126
Defer voteythumbs request (also prettified latex, and deferred xkcd) #126
Conversation
|
As for this PR; lgtm and tested. If you could run black over the repo for code style ( |
ah right, I should've read a bit more into holidays then, soz. and yeah, maybe I'll leave advent for later, might take a bit of a while to wrap my head around. quick q: were xkcd or latex passing beforehand? because I didn't touch the parts that failed checks |
On my machine (and on github) black wants to reformat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (once black passes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I'll give it some time for others to view, but can merge in soon.
I was too hasty. Black is still having some issues. I'm going to have a look at what it is.
Was very minor adjustments, which I think are due to our settings for black (a single line for |
whoops! still learning the ropes, haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and merging
This PR should fix #101 somewhat.
However, some older commands should also be ported to the application-commands framework (
advent
(#68) andholidays
come to mind), and subsequently deferred.Also, this is my first OSS contribution, so I apologize if I've messed up in formatting / protocol for the PR.