Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperating pyproject.toml dependencies #22

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Seperating pyproject.toml dependencies #22

merged 9 commits into from
Aug 8, 2024

Conversation

rdziewietin
Copy link
Contributor

Primarily, this pull request:

  • Moves some functions that do not relate to DocTR out of doctr.ocr_functions and moves them to data.post_processing
  • Separates the DocTR and LLM dependencies into app-doctr and app in the pyproject.toml
  • Moves evaluate_cells into post-processing and adds a test

I tested it locally and with Docker. Both of them work and Docker building is significantly faster. Let me know if it works for y'all.

Copy link
Contributor

@ginic ginic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rdziewietin ! This is a really helpful way to reorganize the code and more unit tests are chef's kiss!

I just have one minor suggestion about removing an unused function.

Co-authored-by: Virginia Partridge <[email protected]>
Copy link
Contributor

@ginic ginic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@rdziewietin rdziewietin merged commit 1991c2f into main Aug 8, 2024
5 checks passed
@rdziewietin rdziewietin deleted the docker-testing branch August 8, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants