-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperating pyproject.toml dependencies #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rdziewietin ! This is a really helpful way to reorganize the code and more unit tests are chef's kiss!
I just have one minor suggestion about removing an unused function.
Co-authored-by: Virginia Partridge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
Primarily, this pull request:
I tested it locally and with Docker. Both of them work and Docker building is significantly faster. Let me know if it works for y'all.