-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.28 #2866
Draft
Gerrit0
wants to merge
72
commits into
master
Choose a base branch
from
beta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add top margin to `.tsd-breadcrumb` in mobile screen - Remove top margin from `.tsd-navigation.settings` - Remove top padding from `.col-sidebar` on single sidebar - Remove margin for `.site-menu` on larger screens
- Move selectors (`#tsd-toolbar-links`, tag selectors) to a relevant place. - Remove classes (`.table-cell`, `.no-caption`, `.tsd-toolbar-icon`), and merge their styles to other common classes.
…cript - **theme_search_index_not_available** - **theme_search_no_results** - theme_search_placeholder - **theme_search_no_recent_searches**
- Use HTML dialog element as popup - Use ARIA-spec compliant "combobox with list autocomplete" pattern for search - Add entry animations - Comment out affected dead code for keyboard event listeners
- store recent searches (that were clicked) in localStorage, with `tsd-search-recent` key - Omit `matchData` property in `res`'s type to make it compatible with recent searches stored in localStorage. - This implementation prevents broken links, but refs might change, changing the suggestions
- fix typo (requierd -> required) - Remove unnecessary try-catch - Add falsy check for document.getElementById argument to avoid console warning in firefox
All children of a listbox must be options, showing error message in an li tag without role=option was invalid. An alternative approach is to use another element with aria-live=polite attribute, to announce the results to the user. However, consecutive queries with no results wouldn't be announced (because the message would be the same), so add search query as part of the message to make it dynamic - Add a new element with aria-live and aria-atomic attributes for a helpful message - Remove unnecessary attribute selector for search results. - Add styles height/margin styles for non-empty elements only. - Add maxLength to input
- Add background-active and contrast-text css properties - update text-aside, menu-item-active color in light theme - break light and dark colors in separate selectors to make them easier to work with "contrast-text" slightly improves contrast. though, not enough to pass WCAG level AAA
The router implementation used by TypeDoc now indicates that in a 22.5 second run rendering all of `@types/node`, 65ms is spent getting URLs. The extra complexity in attempting to cache the result of this frankly isn't worth it. HTML rendering took 16.8 seconds, of which 13.6 seconds was just doing syntax highlighting. Shiki is the most obvious place to spend time investigating performance improvements at this point.
Resolves #2111
Update Chinese translations for beta
It will now behave correctly if a custom theme overrides `getReflectionClasses` to include additional non-filter classes.
Implement Search as ARIA spec compliant* dialog and combobox pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.