Skip to content

Added typescript@next work-around for node_modules #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2016

Conversation

cartant
Copy link
Contributor

@cartant cartant commented Aug 5, 2016

Initial attempt at a work-around for typescript@next to avoid re-compilations for each cache miss on files in node_modules - see #172.

@cartant
Copy link
Contributor Author

cartant commented Aug 5, 2016

This seems to work okay with typescript@next, but it doesn't work with typescript@beta - as the latter simply refuses to emit anything under node_modules, regardless of the roots passed to createProgram. According to this comment, the change that should fix the beta has been merged with the 2.0.0 release.

@cartant cartant force-pushed the issue-172 branch 3 times, most recently from d7c2d90 to 8956a56 Compare August 7, 2016 10:30
@tgrecojs
Copy link

tgrecojs commented Aug 8, 2016

@cartant this may be a "stupid" question, but what is the inherent difference between installing typescript@beta vs typescript@next?

@cartant
Copy link
Contributor Author

cartant commented Aug 8, 2016

@thomasjosephgreco Not a stupid question at all. If you run npm info typescript, you'll see the versions installed in the dist-tags:

{ name: 'typescript',
  description: 'TypeScript is a language for application scale JavaScript development',
  'dist-tags': { latest: '1.8.10', next: '2.1.0-dev.20160808', beta: '2.0.0' },

So typescript@beta is installing the current 2.0.0 beta release and typescript@next is installing what is essentially the current master - a nightly build. (I find it pretty confusing that the beta's semver is not a pre-release. That is, it's not something like 2.0.0-beta.)

If you want to see what the differences between 2.0 and 2.1 will be, there is the roadmap.

@cartant cartant force-pushed the issue-172 branch 2 times, most recently from 07ccfb1 to 09bb085 Compare August 11, 2016 08:38
@cartant
Copy link
Contributor Author

cartant commented Aug 31, 2016

It seems that this comment is correct and the fix has been incorporated into the TypeScript 2.0 RC.

@cartant cartant removed the discussion label Sep 1, 2016
@cartant cartant merged commit 8c3ac6c into TypeStrong:master Sep 1, 2016
@cartant cartant deleted the issue-172 branch September 1, 2016 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants