Skip to content

Commit

Permalink
renaming according to the review
Browse files Browse the repository at this point in the history
  • Loading branch information
JohannesMeierSE committed Dec 12, 2024
1 parent 190684d commit 17ee254
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/typir/src/kinds/class/class-kind.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { InferenceRuleNotApplicable } from '../../services/inference.js';
import { TypirServices } from '../../typir.js';
import { TypeCheckStrategy } from '../../utils/utils-type-comparison.js';
import { assertTrue, assertType, toArray } from '../../utils/utils.js';
import { CreateFunctionTypeDetails, FunctionPredefinedService } from '../function/function-kind.js';
import { CreateFunctionTypeDetails, FunctionFactoryService } from '../function/function-kind.js';
import { Kind, isKind } from '../kind.js';
import { ClassTypeInitializer } from './class-initializer.js';
import { ClassType, isClassType } from './class-type.js';
Expand Down Expand Up @@ -180,7 +180,7 @@ export class ClassKind implements Kind, ClassFactoryService {
return `${this.getIdentifierPrefix()}${typeDetails.className}`;
}

getMethodFactory(): FunctionPredefinedService {
getMethodFactory(): FunctionFactoryService {
return this.services.factory.functions;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/typir/src/kinds/function/function-kind.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export type InferFunctionCall<T = unknown> = {
*/


export interface FunctionPredefinedService {
export interface FunctionFactoryService {
create<T>(typeDetails: CreateFunctionTypeDetails<T>): TypeInitializer<FunctionType>;
get(typeDetails: FunctionTypeDetails): TypeReference<FunctionType>;
calculateIdentifier(typeDetails: FunctionTypeDetails): string;
Expand All @@ -118,7 +118,7 @@ export interface FunctionPredefinedService {
* - optional parameters
* - parameters which are used for output AND input
*/
export class FunctionKind implements Kind, TypeGraphListener, FunctionPredefinedService {
export class FunctionKind implements Kind, TypeGraphListener, FunctionFactoryService {
readonly $name: 'FunctionKind';
readonly services: TypirServices;
readonly options: Readonly<FunctionKindOptions>;
Expand Down
4 changes: 2 additions & 2 deletions packages/typir/src/services/operator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import { Type } from '../graph/type-node.js';
import { TypeInitializer } from '../initialization/type-initializer.js';
import { FunctionPredefinedService, NO_PARAMETER_NAME } from '../kinds/function/function-kind.js';
import { FunctionFactoryService, NO_PARAMETER_NAME } from '../kinds/function/function-kind.js';
import { TypirServices } from '../typir.js';
import { NameTypePair, TypeInitializers } from '../utils/utils-definitions.js';
import { toArray } from '../utils/utils.js';
Expand Down Expand Up @@ -174,7 +174,7 @@ export class DefaultOperatorManager implements OperatorManager {
return newOperatorType as unknown as TypeInitializer<Type>;
}

protected getFunctionFactory(): FunctionPredefinedService {
protected getFunctionFactory(): FunctionFactoryService {
return this.services.factory.functions;
}
}
4 changes: 2 additions & 2 deletions packages/typir/src/typir.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import { TypeGraph } from './graph/type-graph.js';
import { BottomFactoryService, BottomKind } from './kinds/bottom/bottom-kind.js';
import { ClassFactoryService, ClassKind } from './kinds/class/class-kind.js';
import { FunctionKind, FunctionPredefinedService } from './kinds/function/function-kind.js';
import { FunctionKind, FunctionFactoryService } from './kinds/function/function-kind.js';
import { PrimitiveFactoryService, PrimitiveKind } from './kinds/primitive/primitive-kind.js';
import { TopFactoryService, TopKind } from './kinds/top/top-kind.js';
import { DefaultTypeAssignability, TypeAssignability } from './services/assignability.js';
Expand Down Expand Up @@ -60,7 +60,7 @@ export type TypirServices = {
};
readonly factory: {
readonly primitives: PrimitiveFactoryService;
readonly functions: FunctionPredefinedService;
readonly functions: FunctionFactoryService;
readonly classes: ClassFactoryService;
readonly top: TopFactoryService;
readonly bottom: BottomFactoryService;
Expand Down

0 comments on commit 17ee254

Please sign in to comment.