fix glob-to-regexp d.ts

[AlexTugarev]

Signed-off-by: Alex Tugarev [email protected]

[AlexTugarev]

The issue is, that DocumentFilters like { pattern: ".*"} cannot be used, as the type definition refers to an ES6 module, but glob-to-regexp is not a such. Also, the function is only called if only pattern is provided.

[akosyakov]

Do we need to delcare module then at all? https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-function-d-ts.html looks like we should be able to declare a function and export it

[AlexTugarev]

module declaration is needed if import ... from "module" syntax should stay, cf. microsoft/TypeScript#5073.

[akosyakov]

if we use import x = require('module') then it should not be necessary

[AlexTugarev]

well, it's still required.

[ts]
Could not find a declaration file for module 'glob-to-regexp'. '/Users/tugarev/Projects/monaco-languageclient/node_modules/glob-to-regexp/index.js' implicitly has an 'any' type.
Try npm install @types/glob-to-regexp if it exists or add a new declaration (.d.ts) file containing declare module 'glob-to-regexp';

[AlexTugarev]

I double-checked that, it's required if types should be imported, right? module-function.d.ts seems to be misleading.

[akosyakov]

import globToRegExp = require('glob-to-regexp') should be used

[AlexTugarev]

should I change it?

[akosyakov]

yes, please, I think it is bogus to use es6 syntax to import not es6 modules

[AlexTugarev]

👍

[akosyakov]

@AlexTugarev I've sent you an invitation, please accept it and merge the PR