Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve collab cursor code #1405

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: improve collab cursor code #1405

merged 2 commits into from
Feb 7, 2025

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Jan 30, 2025

fixes:

  • Heard from a user they sometimes pass provider: undefined in which case we'd throw an error (fixed with provider?.awareness)
  • "I would like to use showCursorLabels: 'activity', but it is not compatible with renderCursor"

TODO:

  • test
  • organize code better, this should not belong in BlockNoteExtensions.ts

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Feb 7, 2025 1:08pm
blocknote-website ✅ Ready (Inspect) Visit Preview Feb 7, 2025 1:08pm

@matthewlipski
Copy link
Collaborator

For the tests, I suppose we need to change our testing setup? Since I guess it only makes sense to use e2e tests for this, and we need to be able to capture screenshots of 2 editors in the same frame.

@YousefED
Copy link
Collaborator Author

YousefED commented Feb 7, 2025

@matthewlipski manual testing is ok for this now (I didn't test the changes, only reorganized the code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants