SLM-250: close LOT1-01 not_authorized via activation-gate evaluator (restored) - #927
Conversation
LOT1-01's own hard activation gates require SLM-248's fidelity-contract verdict to be authorize_bounded_implementation and SLM-249's trace gate verdict to be oracle_ceiling_positive. The real committed upstream artifacts report needs_target_trace_contract and inconclusive respectively (SLM-249's own allowed_lot1_implementation field says "none: ... not authorized by this issue"). Per the issue's own text, this closes not_authorized in plan-only mode without any Kxc model/training code. Adds a small, reusable, tested LotusOpenUIModelContractV1 evaluator that reads the two upstream contracts and derives the verdict from their real published fields (not hardcoded to always fail — a synthetic both-gates-met case is tested to flip the result to authorized_wiring_only). Re-running the same CLI after SLM-249 gets a real oracle-ceiling campaign will honestly reflect the new disposition. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KShriKrGosZr67yVPFgi78
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…uthorized # Conflicts: # src/slm_training/resources/versions.json
Summary
Restores the SLM-250 LOT1-01
not_authorizedcloseout that was dropped when PR #895 was rewritten (the slice previously lived in commit0205fc66on that branch; #895 now carries only SLM-300 content). Cherry-picked onto currentmainwith theversions.jsonconflict resolved (harness.experimentsbumped v108 → v109 on top of main's registry).LOT1-01's own hard activation gates require SLM-248's fidelity-contract verdict to be
authorize_bounded_implementationand SLM-249's trace gate verdict to beoracle_ceiling_positive. The real committed upstream artifacts reportneeds_target_trace_contractandinconclusiverespectively (SLM-249's ownallowed_lot1_implementationsays none is authorized). Per the issue text, this closesnot_authorizedin plan-only mode without any K×c model/training code.Adds a small, reusable, tested
LotusOpenUIModelContractV1evaluator that reads the two upstream contracts and derives the verdict from their real published fields (not hardcoded to always fail — a synthetic both-gates-met case is tested to flip the result toauthorized_wiring_only). Re-running the same CLI after a real oracle-ceiling campaign honestly reflects the new disposition.Verification
pytest tests/test_harnesses/experiments/test_lot1_01_activation_gate.py tests/test_scripts/test_evaluate_lot1_01_activation_gate.py -q— 9 passedpython -m scripts.evaluate_lot1_01_activation_gate— exit 0, both gates report unmet against the post-SLM-249 (LOT0-02): define CompilerReasoningTraceV1 target-trace contract #909 merged artifactspython -m scripts.verify_version_stamps --check— okpython -m scripts.repo_policy— okgit diff --check— cleanHonest scope
oracle_ceiling_positive(or SLM-248 is amended), re-run the evaluator — it reads the contracts live and flips to authorized; LOT1-01 implementation should then be re-filed.