Skip to content

SLM-250: close LOT1-01 not_authorized via activation-gate evaluator (restored) - #927

Merged
Tyler-R-Kendrick merged 2 commits into
mainfrom
slm-250-lot1-01-not-authorized
Jul 26, 2026
Merged

SLM-250: close LOT1-01 not_authorized via activation-gate evaluator (restored)#927
Tyler-R-Kendrick merged 2 commits into
mainfrom
slm-250-lot1-01-not-authorized

Conversation

@Tyler-R-Kendrick

Copy link
Copy Markdown
Owner

Summary

Restores the SLM-250 LOT1-01 not_authorized closeout that was dropped when PR #895 was rewritten (the slice previously lived in commit 0205fc66 on that branch; #895 now carries only SLM-300 content). Cherry-picked onto current main with the versions.json conflict resolved (harness.experiments bumped v108 → v109 on top of main's registry).

LOT1-01's own hard activation gates require SLM-248's fidelity-contract verdict to be authorize_bounded_implementation and SLM-249's trace gate verdict to be oracle_ceiling_positive. The real committed upstream artifacts report needs_target_trace_contract and inconclusive respectively (SLM-249's own allowed_lot1_implementation says none is authorized). Per the issue text, this closes not_authorized in plan-only mode without any K×c model/training code.

Adds a small, reusable, tested LotusOpenUIModelContractV1 evaluator that reads the two upstream contracts and derives the verdict from their real published fields (not hardcoded to always fail — a synthetic both-gates-met case is tested to flip the result to authorized_wiring_only). Re-running the same CLI after a real oracle-ceiling campaign honestly reflects the new disposition.

Verification

  • pytest tests/test_harnesses/experiments/test_lot1_01_activation_gate.py tests/test_scripts/test_evaluate_lot1_01_activation_gate.py -q — 9 passed
  • python -m scripts.evaluate_lot1_01_activation_gate — exit 0, both gates report unmet against the post-SLM-249 (LOT0-02): define CompilerReasoningTraceV1 target-trace contract #909 merged artifacts
  • python -m scripts.verify_version_stamps --check — ok
  • python -m scripts.repo_policy — ok
  • git diff --check — clean

Honest scope

  • Plan-only/fixture closeout: no K×c latent model code, no GPU training, no production default change, no semantic/quality claim.
  • Successor trigger: if a future trace-gate revision returns oracle_ceiling_positive (or SLM-248 is amended), re-run the evaluator — it reads the contracts live and flips to authorized; LOT1-01 implementation should then be re-filed.

LOT1-01's own hard activation gates require SLM-248's fidelity-contract
verdict to be authorize_bounded_implementation and SLM-249's trace gate
verdict to be oracle_ceiling_positive. The real committed upstream
artifacts report needs_target_trace_contract and inconclusive
respectively (SLM-249's own allowed_lot1_implementation field says
"none: ... not authorized by this issue"). Per the issue's own text,
this closes not_authorized in plan-only mode without any Kxc
model/training code.

Adds a small, reusable, tested LotusOpenUIModelContractV1 evaluator
that reads the two upstream contracts and derives the verdict from
their real published fields (not hardcoded to always fail — a
synthetic both-gates-met case is tested to flip the result to
authorized_wiring_only). Re-running the same CLI after SLM-249 gets a
real oracle-ceiling campaign will honestly reflect the new
disposition.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KShriKrGosZr67yVPFgi78
@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
slm-training Ready Ready Preview, Comment Jul 26, 2026 11:01pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Tyler-R-Kendrick, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fed8e18-2676-4757-899c-f0d28eb2d95b

📥 Commits

Reviewing files that changed from the base of the PR and between 7e1fc58 and fbccb67.

📒 Files selected for processing (7)
  • docs/design/iter-slm250-lot1-01-not-authorized-20260725.json
  • docs/design/iter-slm250-lot1-01-not-authorized-20260725.md
  • scripts/evaluate_lot1_01_activation_gate.py
  • src/slm_training/harnesses/experiments/lot1_01_activation_gate.py
  • src/slm_training/resources/versions.json
  • tests/test_harnesses/experiments/test_lot1_01_activation_gate.py
  • tests/test_scripts/test_evaluate_lot1_01_activation_gate.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch slm-250-lot1-01-not-authorized

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…uthorized

# Conflicts:
#	src/slm_training/resources/versions.json
@Tyler-R-Kendrick
Tyler-R-Kendrick merged commit fcc7e8f into main Jul 26, 2026
4 of 6 checks passed
@Tyler-R-Kendrick
Tyler-R-Kendrick deleted the slm-250-lot1-01-not-authorized branch July 26, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants