fix(decode): fail-closed false-singleton + consume min_terminals bound - #1457
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Rubber-duck + adversarial closeout review (agent)Rubber duckWalked the diff for PR #1457 in isolation vs its base. Intent matches the PR summary; docs + version stamps land with the code; tests pin the new invariants. Adversarial
No blocking findings. Proceeding with CI + squash-merge bottom-up. |
b046c6d to
a0f930b
Compare
af82181 to
f490ed9
Compare
When UNKNOWN witness drops leave a lone proven candidate, mark the completion domain incomplete so I2 cannot force a budget-manufactured singleton. Wire certified StaticLalrAdapter.min_terminals into terminal_witness as a negative-direction prune only.
f490ed9 to
92804b6
Compare
Summary
status=incomplete, reasonwitness_false_singleton_risk) so I2 cannot force a budget-manufactured singleton.StaticLalrAdapter.min_terminalsinterminal_witnessas a negative-direction prune only.Test plan
dsl.operators.registryv13,dsl.completion_kernelv21