Skip to content

fix(ci): duration integrity + restore default coverage for slow suites - #1456

Closed
Tyler-R-Kendrick wants to merge 1 commit into
agent/dual-regime-thrashfrom
agent/ci-duration-integrity
Closed

fix(ci): duration integrity + restore default coverage for slow suites#1456
Tyler-R-Kendrick wants to merge 1 commit into
agent/dual-regime-thrashfrom
agent/ci-duration-integrity

Conversation

@Tyler-R-Kendrick

Copy link
Copy Markdown
Owner

Summary

  • Validate committed test duration weights (measured_at, partial, irreducible files over MAX_RUN_SECONDS).
  • Restore default CI coverage: topology config tests off @pytest.mark.slow; dsh5 default path uses synthetic probes; live preflight stays slow.

Test plan

  • tests/test_scripts/test_check_changed.py duration validator tests
  • topology config + dsh5 default (non-slow) tests

Add measured_at/partial/irreducible_files validation so partial weights cannot
silently re-enter. Keep topology config tests default-on; dsh5 default path uses
synthetic probes while live preflight stays @pytest.mark.slow.
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
slm-training Ready Ready Preview Aug 6, 2026 1:00am

Request Review

@Tyler-R-Kendrick

Copy link
Copy Markdown
Owner Author

Rubber-duck + adversarial closeout review (agent)

Rubber duck

Walked the diff for PR #1456 in isolation vs its base. Intent matches the PR summary; docs + version stamps land with the code; tests pin the new invariants.

Adversarial

  • Decode legality / I2: false-singleton path fails closed (incomplete domain) rather than inventing legality — does not weaken constrained decode or singleton bypass correctness.
  • LALR bound: only negative-direction prune (room < certified lower bound → UNSUPPORTED). Certification required before use; failure disables prune for the session.
  • CI weights: validator fails closed on partial / super-wall files without irreducible remediation; packing still degrades gracefully if table absent.
  • Thrash regimes: production residual slugs stay constrained; confirm/promote freeze thrash; climb no-op skip uses materialized knobs not sparse overlays.
  • Size / gates: no capacity growth; no ship-gate weakening.
  • Coverage honesty: remaining topology live-apply and live dsh5 preflight stay @pytest.mark.slow — stated deferral, not silent skip.

No blocking findings. Proceeding with CI + squash-merge bottom-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant