Skip to content

feat: reinstate Liquid Auth #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 27, 2025

Conversation

HashMapsData2Value
Copy link
Contributor

Reinstate Liquids, making it compatible again post v4.

@HashMapsData2Value HashMapsData2Value changed the title feat: reinstate Liquid feat: reinstate Liquid Auth Jun 18, 2025
@drichar
Copy link
Collaborator

drichar commented Jun 18, 2025

Thanks @HashMapsData2Value! I was wondering if/when we'd see Liquid Auth make its return in v4.

Will you be restoring the liquid-auth-backend example and its accompanying README?

I notice there are some artifacts from the v3 docs (2 files containing changes that were probably still on your v3 branch). The files in the docs folder on the main branch are newly rewritten docs for v4: https://txnlab.gitbook.io/use-wallet/

If you could update the new docs to include Liquid Auth that would be fantastic! But bare minimum please remove the v3 docs files so they aren't inserted into v4 documentation.

@HashMapsData2Value
Copy link
Contributor Author

I'll get rid of the docs files! Regarding the backend, we've come up with a way where you don't need to run your own backend. Rather users will be able to use https://debug.liquidauth.com.

Of course, our intention is NOT for people to make use of it as a production-grade equivalent of Wallet Connect.

@pbennett
Copy link
Collaborator

Does it work with iOS yet ?

@HashMapsData2Value
Copy link
Contributor Author

Does it work with iOS yet ?

Yes, though the code/library and the sample app is not yet ready for production usage.

Copy link
Collaborator

@drichar drichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HashMapsData2Value for restoring Liquid Auth in v4.x!

This looks good to merge once the typos in the docs are fixed (see comment). Also, please update your branch with upstream changes.

Once those are addressed, I'll approve and merge.

@drichar drichar merged commit 47e8cd8 into TxnLab:main Jun 27, 2025
1 check passed
@HashMapsData2Value HashMapsData2Value deleted the fix/reinstate-liquid branch June 27, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants