-
-
Notifications
You must be signed in to change notification settings - Fork 39
feat: reinstate Liquid Auth #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reinstate Liquid Auth #376
Conversation
This reverts commit 74fdf73.
chore: prettier chore: fix test chore: prettier fix: replace with official @algorandfoundation chore: remove unused ts expect error chore: prettier fix
docs: cover switch to liquid-auth.on-render.com
docs: cover switch to liquid-auth.on-render.com chore: remove unnecesary ignore path file chore: prettier
lint: prettier chore: typecheck chore: prettier
Thanks @HashMapsData2Value! I was wondering if/when we'd see Liquid Auth make its return in v4. Will you be restoring the I notice there are some artifacts from the v3 docs (2 files containing changes that were probably still on your v3 branch). The files in the If you could update the new docs to include Liquid Auth that would be fantastic! But bare minimum please remove the v3 docs files so they aren't inserted into v4 documentation. |
I'll get rid of the docs files! Regarding the backend, we've come up with a way where you don't need to run your own backend. Rather users will be able to use https://debug.liquidauth.com. Of course, our intention is NOT for people to make use of it as a production-grade equivalent of Wallet Connect. |
Does it work with iOS yet ? |
Yes, though the code/library and the sample app is not yet ready for production usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HashMapsData2Value for restoring Liquid Auth in v4.x!
This looks good to merge once the typos in the docs are fixed (see comment). Also, please update your branch with upstream changes.
Once those are addressed, I'll approve and merge.
Reinstate Liquids, making it compatible again post v4.