-
Notifications
You must be signed in to change notification settings - Fork 226
Move ad.jl
to DynamicPPL
#2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ad.jl
to DynamicPPL
#2158
Conversation
looks like TuringLang/AdvancedMH.jl#88 is breaking things |
Pull Request Test Coverage Report for Build 7935140085Details
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2158 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 21 -1
Lines 1385 1367 -18
======================================
+ Misses 1385 1367 -18 ☔ View full report in Codecov by Sentry. |
This seems to causing method redefine errors, ref #2173 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @sunxd3! Can you add a note about this change to History.md
and release info, so some users depending on Turing internals do not get surprised.
Twin PR from
DynamicPPL.jl
Address: #2141
Description:
getADBackend
s are renamed togetADType
and moved toInference
module as well asLogDensityProblemsAD.ADgradient(ℓ::LogDensityFunction)
LogDensityProblemsAD.ADgradient(adtype, ℓ)
specific to RD and FD are moved to DynamicPPLADgradient
must also gives theadtype
, in Turing, we just use theadtype
from the algorithmWill finish up with the test, once DynamicPPL PR is merged