Avoid computing ess and sup_ess in psis
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the test suite doesn't currently pass because due to some bugs on main. I fixed one in this PR, but not the other. |
Merged
|
(I merged my own PR that lets users skip ESS computations since I wanted to merge a handful of related changes in that PR, but I'm still open to switching to this implementation if we find a way to avoid duplicate computations.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
essandsup_essproperties ofPsisinstead of fields, so that they are lazily computed only if necessary instead of in eachpsiscall. It also fixes some potential issues where variables of one type are then aliased to have a different type, which may cause issues with type inference (it did in older Julia versions at least) and also makes the code more complicated.