Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more NF examples #11

Open
wants to merge 123 commits into
base: main
Choose a base branch
from
Open

more NF examples #11

wants to merge 123 commits into from

Conversation

zuhengxu
Copy link
Member

@zuhengxu zuhengxu commented Jul 13, 2023

as per issue #15

@zuhengxu zuhengxu self-assigned this Jul 13, 2023
@zuhengxu zuhengxu added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 13, 2023
@zuhengxu zuhengxu changed the title more NF examples+ more proper synthetic examples + documentations more NF examples Jul 13, 2023
@yebai
Copy link
Member

yebai commented Mar 5, 2025

@zuhengxu, can you push to merge this PR if nothing significant is standing? Thanks!

@zuhengxu
Copy link
Member Author

zuhengxu commented Mar 6, 2025

No prob! I'll get back to this PR this weekend and hopefully merge it ASAP.

@zuhengxu zuhengxu marked this pull request as ready for review April 10, 2025 21:46
@yebai
Copy link
Member

yebai commented Apr 10, 2025

Could we add a script to test whether all the example models run, e.g. on buildkite GPU?

@zuhengxu
Copy link
Member Author

Yes, let me clean up the Ham VI demo and then add the test script. Currently I can confirm that all the examples run on CPUs by doing

include("demo_..._fllow.jl")

@zuhengxu
Copy link
Member Author

zuhengxu commented Apr 12, 2025

Could we add a script to test whether all the example models run, e.g. on buildkite GPU?

@yebai Currently all the examples are only tested on CPUs. Do you have examples of such script (for testing runs) that I can refer to? (I did do include(...jl) manually for all the demos though.)

In terms of GPU, shall we first merge this PR and do GPU examples/test (#49) on a separate PR? the purpose this PR is just to demonstrate how to define and customize flow layers (at least for those popular flows). I think that to properly take advantage of GPU, we might want some interface adjustment.

@zuhengxu zuhengxu requested a review from sunxd3 April 12, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants