Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark _evaluate!! as noinline #877

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Mar 29, 2025

This is a patch to work around EnzymeAD/Enzyme.jl#2337. I'm mainly pushing this so that it's on a branch & I can experiment on it + so that CI can run.

@penelopeysm penelopeysm force-pushed the py/noinline-evaluate branch from fce71d7 to 3f74c5a Compare March 29, 2025 22:03
Copy link
Contributor

github-actions bot commented Mar 29, 2025

Benchmark Report for Commit ea52a85

Computer Information

Julia Version 1.11.4
Commit 8561cc3d68d (2025-03-10 11:36 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.5 |                 1.6 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                621.5 |                42.1 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                413.1 |                46.9 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1206.5 |                27.9 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3912.1 |                19.9 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1456.3 |                29.3 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                949.6 |                 5.3 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5451.4 |                 4.1 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1127.3 |                 8.2 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              60743.8 |                 3.9 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               9443.3 |                 9.2 |
|               Dynamic |        10 |    mooncake |             typed |   true |                132.5 |                14.3 |
|              Submodel |         1 |    mooncake |             typed |   true |                 25.8 |                 8.0 |
|                   LDA |        12 | reversediff |             typed |   true |                473.0 |                 7.3 |

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (eed80e5) to head (ea52a85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files          34       34           
  Lines        3815     3815           
=======================================
  Hits         3238     3238           
  Misses        577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 29, 2025

Pull Request Test Coverage Report for Build 14193897586

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.965%

Totals Coverage Status
Change from base Build 14127923718: 0.0%
Covered Lines: 3238
Relevant Lines: 3811

💛 - Coveralls

@penelopeysm penelopeysm force-pushed the py/noinline-evaluate branch from 3f74c5a to ea52a85 Compare April 1, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants