Fix JET errors #468
Merged
Fix JET errors #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AdvancedHMC.jl documentation for PR #468 is available at: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 21 21
Lines 1230 1230
=======================================
Hits 928 928
Misses 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yebai
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the JET errors (see #465, #466, #467) that are caused by DataStructures 0.19.
The package-wide analysis of JET is solely based on the function definitions, and for untyped arguments this means JET only reasons with
Any. Prior to DataStructures 0.19 and itsmergedefinitions, this was sufficient to infer that(iterations = i, ..., tstat..., mass_matrix=metric)is aNamedTuple; with DataStructures >= 0.19, however, it could in principle also be aDataStructures.SortedMultiDict. The PR fixes the problem by adding type annotations to a few functions.