Add ComponentArrays extension #407
Open
+62
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebai
reviewed
Mar 17, 2025
There was a problem hiding this comment.
I'm not familiar with ComponentArrays. Can @mhauru, @penelopeysm, or @sunxd3 take a look, please?
devmotion
reviewed
Mar 17, 2025
| @@ -61,7 +61,7 @@ struct PhasePoint{T<:AbstractVecOrMat{<:AbstractFloat},V<:DualValue} | |||
| ℓπ::V # Cached neg potential energy for the current θ. | |||
| ℓκ::V # Cached neg kinect energy for the current r. | |||
| function PhasePoint(θ::T, r::T, ℓπ::V, ℓκ::V) where {T,V} | |||
| @argcheck length(θ) == length(r) == length(ℓπ.gradient) == length(ℓπ.gradient) | |||
| @argcheck length(θ) == length(r) == length(ℓπ.gradient) == length(ℓκ.gradient) | |||
There was a problem hiding this comment.
This is a separate change (which I had fixed in a recent PR but maybe it was reverted accidentally when fixing merge conflicts). IMO it deserves a separate PR + test.
Comment on lines
+13
to
+25
| function AdvancedHMC.∂H∂r(h::Hamiltonian{<:UnitEuclideanMetric,<:GaussianKinetic}, r::ComponentArray) | ||
| copy(r) | ||
| end | ||
| function AdvancedHMC.∂H∂r(h::Hamiltonian{<:DiagEuclideanMetric,<:GaussianKinetic}, r::ComponentArray) | ||
| out = similar(r) | ||
| out .= h.metric.M⁻¹ .* r | ||
| return out | ||
| end | ||
| function AdvancedHMC.∂H∂r(h::Hamiltonian{<:DenseEuclideanMetric,<:GaussianKinetic}, r::ComponentArray) | ||
| out = similar(r) | ||
| mul!(out, h.metric.M⁻¹, r) | ||
| return out | ||
| end |
There was a problem hiding this comment.
There's nothing ComponentArray specific in any of these methods. IMO this indicates that the we might just want to improve the existing generic definitions in the package.
There was a problem hiding this comment.
We might be able to use AbstractVector (i.e. AbstractArray{T, 1} where T) here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace: #345
Fix: #344