Skip to content

Conversation

SharkPool-SP
Copy link
Collaborator

Resolves: #1987

I changed some naming or cursors, lmk if some others should be changed as well...

@SharkPool-SP SharkPool-SP changed the title cursor -- translate cursor types cursor -- translate cursor menu Apr 9, 2025
@github-actions github-actions bot added the pr: change existing extension Pull requests that change an existing extension label Apr 9, 2025
@SharkPool-SP SharkPool-SP changed the title cursor -- translate cursor menu cursor.js -- translate cursor menu Apr 9, 2025
Copy link
Contributor

@Brackets-Coder Brackets-Coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to do this preferably add an index for each item like native scratch, so people who dont know english (or the right value cause you changed the naming) can still use the block effectively.

that or we need to make a new block and use a field instead

@SharkPool-SP
Copy link
Collaborator Author

If you are going to do this preferably add an index for each item like native scratch, so people who dont know english (or the right value cause you changed the naming) can still use the block effectively.

that or we need to make a new block and use a field instead

done

@SharkPool-SP
Copy link
Collaborator Author

!format

Copy link

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

@NexusKitten
Copy link
Contributor

NexusKitten commented Apr 10, 2025

GarboMuffin in #1987:

if the names don't match the internal CSS names anymore, a lot of them could have much better names

The current names are meant to parody those used in the CSS "cursor" attribute. These names are not localized to any language except English, and so there's not really a reason to translate them unless we plan to change the names to make them more descriptive. I don't see anything wrong with doing so.

@yuri-kiss

This comment was marked as abuse.

@SharkPool-SP
Copy link
Collaborator Author

before doing that, as their is obviously conflicting opinions, can you consult with the other people...

im fine with no numbers

@yuri-kiss

This comment was marked as abuse.

@SharkPool-SP
Copy link
Collaborator Author

SharkPool-SP commented May 21, 2025

before doing that, as their is obviously conflicting opinions, can you consult with the other people...

im fine with no numbers

that isnt the point. there are other reviewers on this team besides just you and garbomuffin... and this is already a precedence set by scratchfoundation for their translated accept reporters menus.. which this so keenly breaks on purpose now; with no consultation to anyone else before hand in which the PR is involved.

No other reviewers voiced a concern for numbers. Additionally, no other extension in the TW gallery follows that number format.

Sure get the other's opinions, but there doesnt seem to be a point

@yuri-kiss

This comment was marked as abuse.

@GarboMuffin
Copy link
Member

We already have many extensions that have translatable menus without a number fallback or equivalent: Animated Text (when enabling features incompatible with Scratch Lab), Files, Pointer lock, Runtime options, Text, Clipping and blending, Iframe, Pen+ V7, Skins, Sensing+, Key simulation, Mobile keyboard, I stopped looking but there are lots more

Merging this without numbers also does not preclude the future possibility of adding numbers

@GarboMuffin
Copy link
Member

GarboMuffin commented May 21, 2025

Feel free to revert my commit and make the numbers actually work though. I'll approve that

@GarboMuffin GarboMuffin changed the title cursor.js -- translate cursor menu cursor: translate cursor menu May 21, 2025
@yuri-kiss

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor.js doesn't translate certain dropdowns.
6 participants