-
Notifications
You must be signed in to change notification settings - Fork 284
cursor: translate cursor menu #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to do this preferably add an index for each item like native scratch, so people who dont know english (or the right value cause you changed the naming) can still use the block effectively.
that or we need to make a new block and use a field instead
done |
!format |
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
GarboMuffin in #1987:
The current names are meant to parody those used in the CSS "cursor" attribute. These names are not localized to any language except English, and so there's not really a reason to translate them unless we plan to change the names to make them more descriptive. I don't see anything wrong with doing so. |
This comment was marked as abuse.
This comment was marked as abuse.
im fine with no numbers |
This comment was marked as abuse.
This comment was marked as abuse.
No other reviewers voiced a concern for numbers. Additionally, no other extension in the TW gallery follows that number format. Sure get the other's opinions, but there doesnt seem to be a point |
This comment was marked as abuse.
This comment was marked as abuse.
We already have many extensions that have translatable menus without a number fallback or equivalent: Animated Text (when enabling features incompatible with Scratch Lab), Files, Pointer lock, Runtime options, Text, Clipping and blending, Iframe, Pen+ V7, Skins, Sensing+, Key simulation, Mobile keyboard, I stopped looking but there are lots more Merging this without numbers also does not preclude the future possibility of adding numbers |
Feel free to revert my commit and make the numbers actually work though. I'll approve that |
Resolves: #1987
I changed some naming or cursors, lmk if some others should be changed as well...