Skip to content

Lily/Video: Update volume functions to interact with the project volume #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 21, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions extensions/Lily/Video.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@
/** @type {string} */
this.videoSrc = videoSrc;

/**
* Base volume as set by the scripts in the project, from 0 to 1.
* Does not account for eg. the project being muted.
* @type {number}
*/
this.videoVolume = 1;

this.videoError = false;

this.readyPromise = new Promise((resolve) => {
Expand Down Expand Up @@ -109,6 +116,12 @@
this.emitWasAltered();
}

updateVolume() {
const projectVolume = runtime.audioEngine.inputNode.gain.value;
const trueVolume = this.videoVolume * projectVolume;
this.videoElement.volume = trueVolume;
}

get size() {
if (this.videoDirty) {
this.reuploadVideo();
Expand Down Expand Up @@ -140,8 +153,11 @@

runtime.on("BEFORE_EXECUTE", () => {
for (const skin of renderer._allSkins) {
if (skin instanceof VideoSkin && !skin.videoElement.paused) {
skin.markVideoDirty();
if (skin instanceof VideoSkin) {
skin.updateVolume();
if (!skin.videoElement.paused) {
skin.markVideoDirty();
}
}
}
});
Expand Down Expand Up @@ -598,7 +614,7 @@
case "duration":
return videoSkin.videoElement.duration;
case "volume":
return videoSkin.videoElement.volume * 100;
return videoSkin.videoVolume * 100;
case "width":
return videoSkin.size[0];
case "height":
Expand Down Expand Up @@ -682,7 +698,8 @@
if (!videoSkin) return;

const value = Cast.toNumber(args.VALUE);
videoSkin.videoElement.volume = Math.min(1, Math.max(0, value / 100));
videoSkin.videoVolume = Math.min(1, Math.max(0, value / 100));
videoSkin.updateVolume();
}

setPlaybackRate(args) {
Expand Down
Loading