Skip to content

Quoted empty strings are valid arguments. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Quoted empty strings are valid arguments. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/args-tokenizer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,17 @@ test("empty command", () => {
expect(tokenizeArgs(``)).toEqual([]);
expect(tokenizeArgs(` `)).toEqual([]);
});

test("empty quoted argument", () => {
expect(tokenizeArgs(`a0 "" a1`)).toEqual(["a0", "", "a1"]);
expect(tokenizeArgs(`a0 '' a1`)).toEqual(["a0", "", "a1"]);
expect(tokenizeArgs(`a0 ""''""'' a1`)).toEqual(["a0", "", "a1"]);
// the next test fails, when the erroneous unescaping of newlines in double quotes is fixed
// correct test is:
// expect(tokenizeArgs(`"a0" "\\\n" a1`)).toEqual(["a0", "", "a1"]);
expect(tokenizeArgs(`"a0" "\\\n" a1`)).toEqual(["a0", "\n", "a1"]);
// the next test fails, when the erroneous unescaping in single quotes is fixed
// correct test is:
// expect(tokenizeArgs(`"a0" '\\\n' a1`)).toEqual(["a0", "\\\n", "a1"]);
expect(tokenizeArgs(`"a0" '\\\n' a1`)).toEqual(["a0", "\n", "a1"]);
});
5 changes: 4 additions & 1 deletion src/args-tokenizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const tokenizeArgs = (
let currentToken = "";
let openningQuote: undefined | string;
let escaped = false;
let quoted_arg = false;
for (let index = 0; index < argsString.length; index += 1) {
const char = argsString[index];

Expand All @@ -34,9 +35,10 @@ export const tokenizeArgs = (
}

if (openningQuote === undefined && spaceRegex.test(char)) {
if (currentToken.length > 0) {
if (currentToken.length > 0 || quoted_arg) {
tokens.push(currentToken);
currentToken = "";
quoted_arg = false;
}
continue;
}
Expand All @@ -47,6 +49,7 @@ export const tokenizeArgs = (
continue;
}
if (openningQuote === char) {
quoted_arg = true;
openningQuote = undefined;
continue;
}
Expand Down