Added typescript-eslint to the project #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
force-pushed
the
add-eslint
branch
from
baa1e8f to
7f977b0
Compare
mike182uk
force-pushed
the
add-eslint
branch
from
7f977b0 to
923f44f
Compare
mike182uk
force-pushed
the
add-eslint
branch
from
923f44f to
3a3e987
Compare
mike182uk
force-pushed
the
add-eslint
branch
from
3a3e987 to
bce39ac
Compare
mike182uk
force-pushed
the
add-eslint
branch
from
bce39ac to
88cf8f0
Compare
refs [AP-330](https://linear.app/tryghost/issue/AP-330/linting-needs-to-be-configured-for-tryghostactivitypub) Added typescript-eslint to the project and configured it to use the recommended rules from eslint / typescript-eslint and the sytlistic rules from typescript-eslint. All violations have been fixed except for some `@typescript-eslint/no-explicit-any` violations which may need a larger refactor to fix. For now `@typescript-eslint/no-explicit-any` violations have been set to `warn` instead of `error` until we can fix them.
mike182uk
force-pushed
the
add-eslint
branch
from
88cf8f0 to
92b9695
Compare
mike182uk
changed the title
|
I have also added in the configuration for |
|
Closing this as its out of date and we are looking at utilising different tooling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs AP-330
Added typescript-eslint to the project and configured it to use the recommended rules from eslint / typescript-eslint and the sytlistic rules from typescript-eslint.
All violations have been fixed except for some
@typescript-eslint/no-explicit-anyviolations which may need a larger refactor to fix.For now
@typescript-eslint/no-explicit-anyviolations have been set towarninstead oferroruntil we can fix them.