Use constants for common strings #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
commented
Jul 25, 2024
src/user.ts
Outdated
| @@ -61,18 +66,6 @@ export async function getUserData(ctx: RequestContext<ContextData>, handle: stri | |||
| ), | |||
| }; | |||
|
|
|||
| const dataToStore: PersonData = { | |||
There was a problem hiding this comment.
Removed this as it wasn't being used
There was a problem hiding this comment.
:D This is actually a bug - we should be passing dataToStore on line 76 🙈
allouis
reviewed
Jul 29, 2024
src/user.ts
Outdated
| @@ -61,18 +66,6 @@ export async function getUserData(ctx: RequestContext<ContextData>, handle: stri | |||
| ), | |||
| }; | |||
|
|
|||
| const dataToStore: PersonData = { | |||
There was a problem hiding this comment.
:D This is actually a bug - we should be passing dataToStore on line 76 🙈
allouis
approved these changes
Jul 30, 2024
mike182uk
force-pushed
the
refactor/use-constants
branch
from
a32d935 to
5df89c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5 we introduced constants to keep track of common strings. This PR updates the codebase to make use of these constants