Added reverse-chronological ordering to outbox items #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
commented
Aug 29, 2024
mike182uk
commented
Aug 29, 2024
mike182uk
commented
Aug 29, 2024
refs [AP-371](https://linear.app/tryghost/issue/AP-371/outbox-item-ordering-is-not-in-reverse-chronological-order) Added reverse-chronological ordering to outbox items by reversing the order of the items in the outbox before dispatching them. This could be improved by comparing the `published` property on the object associated with the outbox item, but for now this is a good enough.
mike182uk
force-pushed
the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
from
46dfee1 to
e0b15f2
Compare
mike182uk
commented
Aug 29, 2024
mike182uk
force-pushed
the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
from
68ab2d2 to
07bf515
Compare
mike182uk
force-pushed
the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
from
07bf515 to
2510378
Compare
mike182uk
commented
Aug 30, 2024
| @@ -1,14 +0,0 @@ | |||
| Feature: Outbox | |||
There was a problem hiding this comment.
This wasn't working as expected and I wasn't keen on the implementation of the steps. I've decided to cover this functionality in the added unit test as its clearer whats happening / quicker to execute
mike182uk
force-pushed
the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
from
2510378 to
1cc3629
Compare
mike182uk
force-pushed
the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
from
1cc3629 to
81bf242
Compare
mike182uk
force-pushed
the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
from
81bf242 to
c4f0ba4
Compare
mike182uk
force-pushed
the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
from
c4f0ba4 to
e32481d
Compare
mike182uk
deleted the
mike-ap-371-outbox-item-ordering-is-not-in-reverse-chronological-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs AP-371
Added reverse-chronological ordering to outbox items by reversing the order of the items in the outbox before dispatching them. This could be improved by comparing the
publishedproperty on the object associated with the outbox item, but for now this is good enough.