-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added announce handling #13
Conversation
src/app.ts
Outdated
@@ -105,6 +111,13 @@ fedify | |||
) | |||
.setCounter(followingCounter); | |||
|
|||
fedify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're using this - then I think we need to remove the custom inbox handler on line 220, as well as the backing code behind it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Didn't realise we already had an inbox handler 🤦♂️ I'll move the logic to the existing handler and create an issue to refactor the existing handler to utilise setInboxDispatcher
in the future
src/dispatchers.ts
Outdated
const thing = await ctx.data.globaldb.get<StoredThing>([result]); | ||
|
||
// If the object is a string, it's a URI, so we should to look it up | ||
// in the globalDb. If it's not in the globalDb, we should just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long term we probably want to fetch it from the network and store it - but this is fine for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I'm following - In the case of Announce
we retrieve the announced object and store it at the point of handling the Announce
activity. So at this point, we already have the object in the db?
(obviously this is only valid for Announce
activities that have been handled by the handler)
0ac916c
to
8893c0a
Compare
8893c0a
to
8f9381b
Compare
f343e97
to
e50bb2a
Compare
Added announce handling
refs MOM-280