Add generator for sidekiq #17
Conversation
| if options[:authenticate_routes_with_devise] | ||
| readme "README" | ||
| else | ||
| say "\nWe've added Sidekiq routes. Please protect it as necessary to suit your requirements.", |
There was a problem hiding this comment.
Let's update to " ... ... Please protect it with authentication as necessary ... ... ..."
|
I just remembered, we also need to add the command to run the sidekiq to Procfile.dev (or Procfile in general, research) if it exists so it runs when we do "bin/dev" |
rails auto generate Procfile.dev and it seems Procfile is used mostly for the heroku, should I check for both file? |
|
@TheZero0-ctrl We should only support Procfile.dev generated by rails in the beginning, user should have capability to skip this configuration as well. |
| aliases: "-ar", | ||
| default: false, | ||
| desc: "Tell us if you want sidekiq routes to only be accessed by authenticated users. Defaults to false." | ||
| class_option :skip_adding_sidekiq_to_procfile, |
There was a problem hiding this comment.
Let's update to skip_procfile_config / _configuration whichever you want.
| say "Adding sidekiq worker to Procfile.dev", :green | ||
| append_to_file "Procfile.dev", "worker: bundle exec sidekiq" | ||
| else | ||
| say "Procfile.dev not found. Skipping adding sidekiq worker to Procfile.dev", :yellow |
There was a problem hiding this comment.
It's fine to return early if File is not found, we don't need to show file not found message
TheZero0-ctrl
force-pushed
the
generator-for-sidekiq
branch
4 times, most recently
from
cd73ee5 to
c9abf62
Compare
TheZero0-ctrl
force-pushed
the
generator-for-sidekiq
branch
from
c9abf62 to
9f91d3f
Compare
coolprobn
added
the
PR CREATED
TheZero0-ctrl
force-pushed
the
generator-for-sidekiq
branch
2 times, most recently
from
beaea6b to
c5622a5
Compare
TheZero0-ctrl
force-pushed
the
generator-for-sidekiq
branch
from
c5622a5 to
0a4fe67
Compare
No description provided.