Improve testing for previous sdks #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tl-Roberto-Mancinelli
commented
Nov 25, 2024
•
tl-Roberto-Mancinelli
commented
- Added testing for previous sdk
- Remove unnecessary code in cake script
tl-Roberto-Mancinelli
force-pushed
the
code-coverage
branch
from
c9c3ce4 to
0d6bae8
Compare
tl-Roberto-Mancinelli
force-pushed
the
code-coverage
branch
from
3652ac6 to
e83faee
Compare
tl-Roberto-Mancinelli
changed the title
dili91
reviewed
Nov 25, 2024
Comment on lines
+24
to
+35
| - name: Setup .NET 8.0 | ||
| uses: actions/setup-dotnet@v2 | ||
| with: | ||
| dotnet-version: 8.0.x | ||
| - name: Setup .NET 6.0 | ||
| uses: actions/setup-dotnet@v2 | ||
| with: | ||
| dotnet-version: 6.0.x | ||
| - name: Setup .NET 3.1 | ||
| uses: actions/setup-dotnet@v2 | ||
| with: | ||
| dotnet-version: 3.1.x |
There was a problem hiding this comment.
I'm not getting how this extra SDKs are used at CI time. could you shed a light? I don't see a multi-build process/pipeline, but maybe I'm missing something
There was a problem hiding this comment.
The multi build is triggered by the multiple frameworks declared in the test project, I was under the impression that using the latest sdk could also build previous versions of net but that doesn't seem the case in our ci
dili91
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.