refactor: rt/ cleanup (Part II)
#97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code should NOT be left as a comment; it only leaves an unmaintained noise that makes the remaining code harder to deal with.
Trailing whitespaces, missing semi colons, missing trailing comma on objects, odd comment structur, outcommented dead code, odd order of functions, ...
Trailing whitespace, missing semi colons, hard to understand comments, ...
Trailing whitespace, missing semi colons, odd comments, dead code, ...
There is no reason to have an inconsistent access to `scheduer.__currentThread`; one may as well just access it directly (as is done in the Runtime Monitor). Furthermore, why the `__` when the variable is treated as public anyways?
This function is only called in one placed with these arguments given. This is essentially dead code.
There seems to be no reason why we have to have an O(n) unblocking logic. Furthermore, this is much cleaner.
… an enum This much better conveys the meaning of this argument, especially from the call site
This operation seems only designed for the values of the Raw type as is now defined in rawUtil.mts. Yet, it is hard to get it into the type system, as the basic types (number, string, and boolean) do not have a '_troupeType' value. Either this algorithm needs some rewriting and/or we need to redesign the type definition a bit to make it easier for TypeScript to follow.
ssoelvsten
added
📁 ./rt
Draft
These values really ought to be marked as private...
ssoelvsten
force-pushed
the
fork/dev/rt-cleanup-2
branch
from
82fcee2 to
c1c8350
Compare
ssoelvsten
force-pushed
the
fork/dev/rt-cleanup-2
branch
5 times, most recently
from
ddcd496 to
8558bc8
Compare
Having an entire subclass just to change the constructor seems quite unorthodox and is harder to understand than is necessary
Similar to 'LValCopyAt' there is no reason for a subclass just to change the constructor.
ssoelvsten
force-pushed
the
fork/dev/rt-cleanup-2
branch
2 times, most recently
from
543448a to
4a69d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #80 as I'm looking at adding monadic values (generalisation of #66).
In this case, I seemed to have to make changes to the p2p layer. Furthermore, I also would need a cryptographic hash of Troupe values (where the
Hashmodule would not be applicable). Hence, these changes constitute some cleanup and documentation of both.