HAMT Performance Improvements #54
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not per se testing the runtime itself. Rather, they are checking that the standard library actually is correct. Furthermore, the 'hamt_stress.trp' and 'hamt_perf.trp' tests include timing the time to run certain operations. These break on other machines (and presumably also on the same machine).
The git history already documents the fact these functions are 'optimized'...
And once again, make the make target match the convention of also matching the folder's name.
According to an SO post (https://stackoverflow.com/a/41537995/13300643), the other value is a prime number pretty close to the original value. Yet, using that one instead breaks many of the intended properties of the hash function
This is done by emulating the actual original Knuth's multiplicative hash function (fixed for data structures of 2^31 size... or less)
This makes it larger than (most) ASCII characters. This should decrease the number of collisions that happens with any regular string.
This also makes it use a Mersenne prime rather than just a power of two.
ssoelvsten
force-pushed
the
fork/dev-integrity/hamt
branch
from
929de88 to
ff53745
Compare
As you can see, Claude, I got questions...
ssoelvsten
force-pushed
the
fork/dev-integrity/hamt
branch
3 times, most recently
from
d4f33ca to
78e0e98
Compare
ssoelvsten
force-pushed
the
fork/dev-integrity/hamt
branch
from
78e0e98 to
b7736bd
Compare
ssoelvsten
force-pushed
the
fork/dev-integrity/hamt
branch
from
b7736bd to
49b21d0
Compare
This way, if someone else has a `filter`, `map`, and so on, you can still access these functions. Like in SML, the `length` function is exported both as `List.length` and `length`.
ssoelvsten
force-pushed
the
fork/dev-integrity/hamt
branch
from
49b21d0 to
b7d14a1
Compare
ssoelvsten
force-pushed
the
fork/dev-integrity/hamt
branch
from
2d23590 to
c7a2886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I've been looking at the current state of the HAMT. For now, here are all of the associated cleanups I've made.
Makefilestest/libfor Standard Libraryhashfunction into its own Standard Library module for separate testing and reuse.hashfunctions.Here is my roadmap to continue:
Listlibrary use namespaced style (such that there are no conflicts with "overloading" from other parts of the standard library).lengthis still also exported into the global namespace.Unitlibrary - depends(ish) on Library is imported as a closure rather than an array #55StencilVector.trp(useful for separate testing)Map.trpSet.trp