Scripts/Anniversary: Implement Lord Kazzak encounter #30606
Merged
+294
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyr97
reviewed
Jan 18, 2025
| void KilledUnit(Unit* victim) override | ||
| { | ||
| if (victim->GetTypeId() == TYPEID_PLAYER) | ||
| Talk(SAY_KILL, victim); |
There was a problem hiding this comment.
I recommend adding a timestamp check to prevent Talk spamming.
There was a problem hiding this comment.
we can do that in creature_text table at some point
Nyr97
reviewed
Jan 18, 2025
src/server/scripts/Events/Anniversary/boss_lord_kazzak_anniversary.cpp
Outdated
Show resolved
Hide resolved
Nyr97
reviewed
Jan 18, 2025
src/server/scripts/Events/Anniversary/boss_lord_kazzak_anniversary.cpp
Outdated
Show resolved
Hide resolved
Nyr97
reviewed
Jan 18, 2025
src/server/scripts/Events/Anniversary/boss_lord_kazzak_anniversary.cpp
Outdated
Show resolved
Hide resolved
Nyr97
reviewed
Jan 18, 2025
src/server/scripts/Events/Anniversary/boss_lord_kazzak_anniversary.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Tests performed:
Tested in-game
Known issues and TODO list: (add/remove lines as needed)