Skip to content

Added support for only_taxa filtering #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Added support for only_taxa filtering #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d00e80
Added support for only_taxa filtering.
gaurav Feb 19, 2024
e5e2fd4
Fixed NameRes to 2433 to simplify development.
gaurav Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/common/google_sheet_test_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class TestRow:
Conflations: set[str]
BiolinkClasses: set[str]
Prefixes: set[str]
OnlyTaxa: set[str]
Source: str
SourceURL: str
Notes: str
Expand Down Expand Up @@ -59,6 +60,7 @@ def from_data_row(row):
Conflations=set(row.get('Conflations', '').split('|')),
BiolinkClasses=set(row.get('Biolink Classes', '').split('|')),
Prefixes=set(row.get('Prefixes', '').split('|')),
OnlyTaxa=set(row.get('Only Taxa', '').split('|')),
Source=row.get('Source', ''),
SourceURL=row.get('Source URL', ''),
Notes=row.get('Notes', '')
Expand Down
2 changes: 2 additions & 0 deletions tests/nameres/test_nameres_from_gsheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ def test_label(target_info, test_row, test_category):
only_prefixes.append(prefix)
request['only_prefixes'] = "|".join(only_prefixes)
request['exclude_prefixes'] = "|".join(exclude_prefixes)
if test_row.OnlyTaxa:
request['only_taxa'] = '|'.join(list(test_row.OnlyTaxa))

test_summary = f"querying {nameres_url_lookup} with label '{label}' and biolink_type {biolink_class}"
response = requests.get(nameres_url_lookup, params=request)
Expand Down
2 changes: 1 addition & 1 deletion tests/targets.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ NameResURL = https://name-resolution-sri-dev.apps.renci.org/

[localhost]
NodeNormURL = http://localhost:2434/
NameResURL = http://localhost:2435/
NameResURL = http://localhost:2433/