Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file references checks #1096

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Fix file references checks #1096

merged 3 commits into from
Feb 12, 2024
+10 −3

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • When deleting a file from the Files app, the system generates a .Trash folder
  • Trying to delete an item from the Inbox system folder can throw an error

Related tasks

#1094
#1095

Approach

  • Ignore system trash folder
  • Use .isDeletableFile check before deleting and cancelling the import operation

@GianniCarlo GianniCarlo self-assigned this Feb 9, 2024
@GianniCarlo GianniCarlo mentioned this pull request Feb 10, 2024
Open
@GianniCarlo GianniCarlo merged commit bf8a95f into develop Feb 12, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the fix-file-references branch February 12, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo