Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing the import modal on launch for newer phones #1090

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • On newer phones (reproducible on iPhone 15 pro), there are no UIScenes with the foregroundActive status when the library's viewDidAppear event is called. Resulting in the initial scan being called before the import observers are live

Related tasks

#1074

Approach

  • Move the notifyPendingFiles outside of the viewDidAppear of the screen, to now be called after the import observers are initialized on the coordinator

@GianniCarlo GianniCarlo self-assigned this Feb 6, 2024
@GianniCarlo GianniCarlo merged commit 91237a7 into develop Feb 6, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the fix-import-process branch February 6, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant